Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[16.0][MIG] hr_personal_equipment_stock: Migration to 16.0 #1394

Merged
merged 15 commits into from
Nov 13, 2024
Merged

[16.0][MIG] hr_personal_equipment_stock: Migration to 16.0 #1394

merged 15 commits into from
Nov 13, 2024

Conversation

anusriNPS
Copy link

Migrating hr_personal_equipment_stock to 16.0

albariera and others added 14 commits October 28, 2024 16:25
@albariera @anusriNPS
hr_personal_equipment_stock
3229b6e 
Update hr_personal_equipment_stock.pot

README.rst
@etobella @anusriNPS
Added translation using Weblate (Spanish)
6a10886
@albariera @anusriNPS
Translated using Weblate (Spanish)
684fddf 
Currently translated at 66.6% (12 of 18 strings)

Translation: hr-13.0/hr-13.0-hr_personal_equipment_stock
Translate-URL: https://translation.odoo-community.org/projects/hr-13-0/hr-13-0-hr_personal_equipment_stock/es/
@olgamarcocb @anusriNPS
Added translation using Weblate (Spanish)
a67dfd5
@albariera @anusriNPS
hr_personal_equipment_stock: fix partner_id and origin when creating …
c540d9a 
…stock.picking
@albariera @anusriNPS
[IMP] hr_personal_equipment_stock: black, isort, prettier
8942c98
@albariera @anusriNPS
[MIG] hr_personal_equipment_stock: Migration to 14.0
d132447
@anusriNPS
[UPD] Update hr_personal_equipment_stock.pot
ded6381
@OCA-git-bot @anusriNPS
[UPD] README.rst
db94415
@francesco-ooops @anusriNPS
Added translation using Weblate (Italian)
d0f2496
@mymage @anusriNPS
Translated using Weblate (Italian)
4807b95 
Currently translated at 100.0% (21 of 21 strings)

Translation: hr-14.0/hr-14.0-hr_personal_equipment_stock
Translate-URL: https://translation.odoo-community.org/projects/hr-14-0/hr-14-0-hr_personal_equipment_stock/it/
@primes2h @anusriNPS
Translated using Weblate (Italian)
d5c8091 
Currently translated at 100.0% (21 of 21 strings)

Translation: hr-14.0/hr-14.0-hr_personal_equipment_stock
Translate-URL: https://translation.odoo-community.org/projects/hr-14-0/hr-14-0-hr_personal_equipment_stock/it/
@Ivorra78 @anusriNPS
Translated using Weblate (Spanish)
6dbd06c 
Currently translated at 100.0% (21 of 21 strings)

Translation: hr-14.0/hr-14.0-hr_personal_equipment_stock
Translate-URL: https://translation.odoo-community.org/projects/hr-14-0/hr-14-0-hr_personal_equipment_stock/es/
@anusriNPS
[IMP] hr_personal_equipment_stock: pre-commit execution
4e6a7de
@anusriNPS anusriNPS marked this pull request as draft October 28, 2024 16:12
@anusriNPS anusriNPS force-pushed the 16.0-mig-hr_personal_equipment_stock branch 2 times, most recently from 22aa5dc to 338b40b Compare October 29, 2024 15:19
@anusriNPS anusriNPS force-pushed the 16.0-mig-hr_personal_equipment_stock branch from 338b40b to 0adcd1e Compare November 6, 2024 12:21
@anusriNPS
Copy link
Author

Pickings are created when employee equipment request moves to "Accepted" state

Pickings_created_request_accept

However, the same scenario while executed as part of test case, pickings are not created when request moved to "Accepted" state

Testcase_issue

@anusriNPS anusriNPS force-pushed the 16.0-mig-hr_personal_equipment_stock branch from 0adcd1e to 55036c3 Compare November 11, 2024 08:50
@anusriNPS anusriNPS force-pushed the 16.0-mig-hr_personal_equipment_stock branch from 55036c3 to c7ababc Compare November 13, 2024 10:34
@anusriNPS anusriNPS marked this pull request as ready for review November 13, 2024 10:37
aleuffre
aleuffre approved these changes Nov 13, 2024
View reviewed changes
Copy link

@aleuffre aleuffre left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code review, LGTM

renda-dev
renda-dev approved these changes Nov 13, 2024
View reviewed changes
Copy link

@renda-dev renda-dev left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code and functional review, LGTM

@OCA-git-bot
Copy link
Contributor

This PR has the approved label and has been created more than 5 days ago. It should therefore be ready to merge by a maintainer (or a PSC member if the concerned addon has no declared maintainer). 🤖

@renda-dev
Copy link

Greetings,
I personally think that this is quite helpful, could anyone please give this a look and maybe merge?

@OCA/human-resources-maintainers

@dreispt
Copy link
Member

dreispt commented Nov 13, 2024

/ocabot migration hr_personal_equipment_stock
/ocabot merge nobump

@OCA-git-bot
Copy link
Contributor

Hey, thanks for contributing! Proceeding to merge this for you.
Prepared branch 16.0-ocabot-merge-pr-1394-by-dreispt-bump-nobump, awaiting test results.

@OCA-git-bot OCA-git-bot added this to the 16.0 milestone Nov 13, 2024
@OCA-git-bot OCA-git-bot mentioned this pull request Nov 13, 2024
Open
25 tasks
@OCA-git-bot OCA-git-bot merged commit 04c6819 into OCA:16.0 Nov 13, 2024
5 checks passed
@OCA-git-bot
Copy link
Contributor

Congratulations, your PR was merged at 6144019. Thanks a lot for contributing to OCA. ❤️

@renda-dev renda-dev deleted the 16.0-mig-hr_personal_equipment_stock branch November 13, 2024 12:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aleuffre aleuffre aleuffre approved these changes

@renda-dev renda-dev renda-dev approved these changes

@dreispt dreispt dreispt approved these changes

Assignees
No one assigned
Labels
approved merged 🎉 ready to merge
Projects
None yet
Milestone
16.0
Development

Successfully merging this pull request may close these issues.